Re: [PATCH v14 1/5] firmware: Move firmware attributes class helper

[Tzung-Bi Shih]

On Tue, Sep 01, 2026 at 06:48:02PM +0100, Sean Rhodes wrote:
> Move the firmware attributes class helper from drivers/platform/x86 to
> drivers/firmware and expose its class declaration through a public Linux
> header.
> 
> The helper is not x86-specific. Keeping it in drivers/firmware lets
> coreboot firmware drivers use the standard firmware-attributes ABI without
> living under platform/x86.
> 
> Replace the affected drivers' relative helper includes directly with the
> new public header.
> 
> Suggested-by: Derek J. Clark <derekjohn.clark@xxxxxxxxx>
> Reviewed-by: Mark Pearson <mpearson-lenovo@xxxxxxxxx>
> Reviewed-by: Derek J. Clark <derekjohn.clark@xxxxxxxxx>
> Tested-by: Oliver Lin <oliver@xxxxxxxxxxxxxxx>
> Signed-off-by: Sean Rhodes <sean@starlabs.systems>

LGTM,
Reviewed-by: Tzung-Bi Shih <tzungbi@xxxxxxxxxx>