Re: [PATCH v24 03/15] mmc: renesas_sdhi: Add clk_mask field to support flexible clock divider widths

[Wolfram Sang]

> +#define SDHI_CLK_MASK_DEFAULT		0x80000080

ULL suffix maybe?

> @@ -101,6 +101,7 @@ static const struct renesas_sdhi_of_data of_data_rza2 = {
>  	/* DMAC can handle 32bit blk count but only 1 segment */
>  	.max_blk_count	= UINT_MAX / TMIO_MAX_BLK_SIZE,
>  	.max_segs	= 1,
> +	.clk_mask	= SDHI_CLK_MASK_DEFAULT,

I'd vote to not initialize clk_mask when it uses the default value. We
have code handling this case. This makes the instances having a
non-default value more obvious, I'd say.

Attachment: signature.asc
Description: PGP signature