Re: [PATCH v3 01/13] KVM: x86/xen: Rename 'longmode' to 'is_64bit' in hypercall handling

[Paul Durrant]

On 31/08/2026 22:26, David Woodhouse wrote:
> From: David Woodhouse <dwmw@xxxxxxxxxxxx>
>
> Rename the local 'longmode' variable and function parameter to
> 'is_64bit' throughout the Xen hypercall handling code. This
> distinguishes it from the VM-wide kvm->arch.xen.long_mode which
> represents the Xen shared_info layout mode.
>
> The 'is_64bit' parameter indicates whether the vCPU was in 64-bit
> mode when it made the hypercall, which determines how to parse the
> hypercall arguments. The UAPI field name (vcpu->run->xen.u.hcall.longmode)
> is unchanged.

Given that 'longmode' is the term used in the UAPI I'm not sure I really 
see the point in this change (particularly since there is not even a 
name clash with 'long_mode').

> Assisted-by: Kiro:claude-opus-4.6-1m
> Signed-off-by: David Woodhouse <dwmw@xxxxxxxxxxxx>
> ---
>   arch/x86/kvm/xen.c | 26 +++++++++++++-------------
>   1 file changed, 13 insertions(+), 13 deletions(-)