Re: [PATCH v5 1/2] dt-bindings: arm: stm32: Document st,stm32mp23/25-syscfg subnodes and cells

[Marek Vasut]

On 9/1/26 8:11 PM, Conor Dooley wrote:

Hello Conor,

> > @@ -57,10 +68,17 @@ allOf:
> >     - if:
> >         properties:
> >           compatible:
> > -          const: st,stm32mp25-syscfg
> > +          contains:
> > +            enum:
> > +              - st,stm32mp23-syscfg
> > +              - st,stm32mp25-syscfg
> >       then:
> >         required:
> >           - "#clock-cells"
> > +        - "#address-cells"
> > +        - "#size-cells"
> > +        - phy@2400
> > +        - phy@2800
>
> This looks good now, thanks.
>
> I got hung up last time though and maybe didn't notice - in addition to
> requiring these things here, should we also not forbid them on other
> platforms that don't have them? IOW, adding "else: properties: foo: false".

I did add this, and reduced the pattern in patternProperties to match 
only on phy@2400 and phy@2800 so I can disable those too.

> With that, if appropriate,
> Reviewed-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>
I will send a V6 without this tag, please have a look one more time.

Thank you for your help !