Re: [PATCH v2 2/2] arm64: dts: qcom: sm8750: Add Lenovo Legion Y700 Gen4

[Konrad Dybcio]

On 7/26/26 4:30 PM, Pengyu Luo wrote:
> Add an initial devicetree for the Lenovo Legion Y700 Gen4, which is
> based on sm8750-qrd.
> 
> Supported features:
> - Altmode
> - Backlight
> - Battery & Charge (Full speed)
> - Buttons
> - Framebuffer (Require mdss and dispcc to be disabled)
> - USB (Two ports)
> 
> Downstream supported features:
> - Display (8/10 bits) (Nowadays DPU driver is broken for dual dsi panel)
> - GPU
> - Touchscreen

This paragraph is wholly irrelevant given the tree this is targetting

[...]


> +&tlmm {
> +	/* For CDT: <32 3> <37 2> <77 1>; */

What's CDT in this context?

[...]

> +&usb {
> +	dr_mode = "otg";
> +	maximum-speed = "super-speed-plus-gen2x1";

Neither property should be necessary

> +
> +	status = "okay";
> +
> +	ports {
> +		/*
> +		 * USB2.0 is shared for two ports, set pinctrl eusb_mux_default
> +		 * to select the repeter. Plugging out one of them will reset
> +		 * the DWC3, which causes both of them to be disconnected.
> +		 */

Is there a hub inbetween? Or can you only use one port at once for data?

Konrad