Re: [PATCH v2] dt-bindings: hwmon: ti,tmp401: add #thermal-sensor-cells

From: Vincent Jardin

Date: Wed Sep 02 2026 - 11:08:08 EST


Hi Guenter,

> The driver does register thermal zones. Since #thermal-sensor-cells is
> mandatory for using it, I would think that the property is needed.

agree. thanks.

> However, not all chips supported by the driver (and this bindings file)
> have more than one channel, so I suspect that the value range might
> need to be "enum: [0, 1]".

I could switch to "enum: [0, 1]" if you would still prefer it, but
tmp401_probe() sets temp_channel_config[0] and [1] unconditionally (local plus
one remote diode) and tmp432 adds [2] for its second remote.
So each case in this binding has at least two channels and the channel index is always
meaningful. That is why "const: 1" is used, matching national,lm90.yaml,
which covers a mix of 2 and 3 channel chips.

I'll send a v3, that does not change the yaml by that applies the proper comments
per Krzysztof's feedbacks.

best regards,
Vincent