Re: [PATCH v2] dt-bindings: hwmon: ti,tmp401: add #thermal-sensor-cells

[Vincent Jardin]

Hi Krzysztof,

Le 28/08/26 12:02, Krzysztof Kozlowski a écrit :
> On Tue, Aug 25, 2026 at 12:13:18AM +0200, Vincent Jardin wrote:
> > The property is missing, so a board that uses it with a thermal zone fails
> > with dtbs_check:
> > 
> >   tmp411@4c (ti,tmp411): '#thermal-sensor-cells' does not match any of the
> 
> Cannot find such node.
> 
> How can I reproduce this warning? If it is non-reproducible, then it is
> not a valid reason for a change and instead driver implementing thermal
> sensor would be the proper reason.

Hmm, you are right, it is not reproducible from the main tree, I was confused
with my ongoing developments: no in-tree DTS uses a tmp401-family
chip as a thermal sensor, so dtbs_check has nothing to complain about.

The warning came from a DTS that does, which is exactly the usage the
driver now supports and you are right that the driver, not the
warning, is the proper reason.

Since commit
  a3b61ba2558e ("hwmon: (tmp401) register with thermal subsystem"),
in v7.3-rc1, tmp401 sets HWMON_C_REGISTER_TZ

-> the hwmon core calls devm_thermal_of_zone_register() for every
temperature channel.

My goal is to unify/follow the other ones such as national,lm90.yaml,
ti,tmp102.yaml or adi,adt7470.yaml already pair "const: 1" with drivers
that set HWMON_C_REGISTER_TZ.

v3 justifies the change from the driver and drops the dtbs_check excerpt.
The diff is unchanged.

Thanks for catching it and sorry for the confusions,
  Vincent