Re: [PATCH v2.1] mm/damon/core: fix false positive in damos_quota_is_full() when esz is zero

[SJ Park]

On Wed,  2 Sep 2026 22:22:31 +0800 Liew Rui Yan <aethernet65535@xxxxxxxxx> wrote:

> On Wed, 02 Sep 2026 07:10:00 -0700 SJ Park <sj@xxxxxxxxxx> wrote:
> 
> > On Wed,  2 Sep 2026 16:44:45 +0800 Liew Rui Yan <aethernet65535@xxxxxxxxx> wrote:
> > 
> > > When setting goal_tuner to 'temporal', if the goal is achieved,
> > > quota->esz_bp will be set to zero.  In this case, damos_quota_is_full()
> > > will always return true, even if no regions have been tried to apply at
> > > all.  This causes qt_exceeds to increase unexpectedly.
> > 
> > To me, this looks logically correct.  Could this cause any user issue?
> 
> Yes, I think this might cause unnecessary confusion for users,

If it is _might_ kind thing, please ask questions first, or add RFC tag at
least.

> at least
> it did for me.

If it confused you, definitely we need to fix it.  But if it is just confusing,
let's try to clarify by adding documentation, rather than changing existing
behaviors.

I feel like we also found similar case that people send patches to change some
behaviors that confusing them, but not really problematic.  That sometimes
waste unnecessary time for understanding the intention of the patch.  Please
feel free to ask question first, if you found some confusing behaviors and
don't know why it behaves in the way or if it is a real problem.


Thanks,
SJ

[...]