Re: [PATCH v4 4/5] x86/amd_node: Skip SMN setup on Hygon Fam18h models 0x04-0x08

[Borislav Petkov]

On Wed, Sep 02, 2026 at 02:22:13PM +0800, Lin Wang wrote:
> Please let me know how you would prefer this to be handled.

Well, X86_FEATURE_ZEN isn't Hygon apparently. Otherwise, we wouldn't be having
this conversation. And we wouldn't need ugly workarounds like that.

Which means, you cannot set it on Hygon. Instead, you should check vendor or
define your own X86_FEATURE_HYGON if you think it would be useful to denote
common set of features between all Hygon cores.

Reusing an AMD-specific flag but then having different hardware which needs
hacks and workarounds to the code is not what you do. Hygon is a different
vendor and it should be treated as such - not piggyback on AMD code.

Unless you wanna piggyback. But then you have to extract it properly and make
it generic so that it can be shared. I have been asking all people submitting
Hygon code to do that and you are starting to do it but then you need to stick
to it and do only that.

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette