Re: [PATCH] arm64: dts: qcom: x1-denali: Add volume up/down GPIO keys

[Konrad Dybcio]

On 8/31/26 5:51 PM, Dale Whinham wrote:
> On Mon, 31 Aug 2026 at 08:13, Konrad Dybcio
> <konrad.dybcio@xxxxxxxxxxxxxxxx> wrote:
>> Let's order the pin nodes by their gpio number
>>
>> otherwise:
>>
>> Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx>
>>
>> Konrad
> 
> (Resending as plain text, apologies)
> 
> Thank you Konrad - how about the gpio-keys { } section, should we
> re-order them to:
> 
> key-vol-up   { pm8550 6 }
> key-vol-down { pm8850 8 }
> switch-lid   { tlmm 2 }

Generally if there's not a better criterion, nodes are supposed to be
ordered by their unit address (the number after '@' - none here) or
their name

via

https://docs.kernel.org/devicetree/bindings/dts-coding-style.html#order-of-nodes

Konrad