Re: [PATCH v7 1/2] ASoC: Intel: Add Cherry Trail RT5677 machine driver

[Mark Brown]

On Wed, Sep 02, 2026 at 02:30:06PM +0200, Maurizio Casciano wrote:
> The Lenovo Yoga Book YB1-X91F/L uses the Cherry Trail SSP2 link with
> an RT5677 codec and a TS3A227E headset detector. Its amplifiers and
> headphone path also need board-specific GPIO sequencing.

> +static int cht_rt5677_aif1_hw_params(struct snd_pcm_substream *substream,
> +				     struct snd_pcm_hw_params *params)
> +{
> +	struct snd_soc_pcm_runtime *rtd = substream->private_data;
> +	struct snd_soc_dai *codec_dai = snd_soc_rtd_to_codec(rtd, 0);

snd_soc_substream_to_rtd()

> +static const struct snd_soc_aux_dev cht_rt5677_headset_dev = {
> +	.dlc = COMP_AUX("i2c-ts3a227e"),

Shouldn't this be using an ACPI formatted name?  Doesn't really matter I
guess but other Intel stuff does.

> +static const struct acpi_gpio_mapping cht_rt5677_gpios[] = {
> +	{ "speaker-enable-gpios", &speaker_enable_gpio, 1 },
> +	{ }
> +};

We ask for more names below...

Attachment: signature.asc
Description: PGP signature