Re: [PATCH] Documentation: trace: histogram-design: fix bracket

From: Randy Dunlap

Date: Wed Sep 02 2026 - 13:43:01 EST




On 9/2/26 8:10 AM, Manuel Ebner wrote:
> Remove needless ')' from sentence.
>
> Signed-off-by: Manuel Ebner <manuelebnerli@xxxxxxxxxxx>
> ---
> Documentation/trace/histogram-design.rst | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/trace/histogram-design.rst b/Documentation/trace/histogram-design.rst
> index 41a726cd3..b757afa22 100644
> --- a/Documentation/trace/histogram-design.rst
> +++ b/Documentation/trace/histogram-design.rst
> @@ -876,7 +876,7 @@ next_pid field on this sched_switch event, we retrieve the
> variables specified in the wakeup_latency() trace action, and use
> them to generate a new wakeup_latency event into the trace stream.
>
> -Note that the way the trace handlers such as wakeup_latency() (which
> +Note that the way the trace handlers such as wakeup_latency() which
> could equivalently be written trace(wakeup_latency,$wakeup_lat,next_pid)
> are implemented, the parameters specified to the trace handler must be
> variables. In this case, $wakeup_lat is obviously a variable, but

Seems to me that the "which ..." should be a parenthetical phrase,
i.e., with parentheses at both ends of it. IMO.
But let's see the the TRACE maintainers have an opinion about it.


--
~Randy