Re: [PATCH] docs: locking: Fix bracket

[Randy Dunlap]

On 9/2/26 7:58 AM, Jan Kara wrote:
> On Wed 02-09-26 16:39:38, Manuel Ebner wrote:
>> Remove needless '(' from code block.
>>
>> Signed-off-by: Manuel Ebner <manuelebnerli@xxxxxxxxxxx>
> 
> Looks good. Feel free to add:
> 
> Reviewed-by: Jan Kara <jack@xxxxxxx>

Reviewed-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>

> 
>> ---
>> Should I also replace ')(' with ') (' as it is in the second code block?
>> It would improve readability in my opinion.
> 
> Dunno, at least I'm used to the way which is written here :)

I agree - this looks typical to me.

> 
> 								Honza
> 
>> ---
>>  Documentation/filesystems/locking.rst | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/Documentation/filesystems/locking.rst b/Documentation/filesystems/locking.rst
>> index 844d65eb4..1598cf555 100644
>> --- a/Documentation/filesystems/locking.rst
>> +++ b/Documentation/filesystems/locking.rst
>> @@ -27,7 +27,7 @@ prototypes::
>>  	int (*d_init)(struct dentry *);
>>  	void (*d_release)(struct dentry *);
>>  	void (*d_iput)(struct dentry *, struct inode *);
>> -	char *(*d_dname)((struct dentry *dentry, char *buffer, int buflen);
>> +	char *(*d_dname)(struct dentry *dentry, char *buffer, int buflen);
>>  	struct vfsmount *(*d_automount)(struct path *path);
>>  	int (*d_manage)(const struct path *, bool);
>>  	struct dentry *(*d_real)(struct dentry *, enum d_real_type type);
>> -- 
>> 2.54.0
>>

-- 
~Randy