Re: [PATCH v2] sparc: NMI: Remove obsolete comment
From: Randy Dunlap
Date: Wed Sep 02 2026 - 14:17:31 EST
On 9/2/26 4:30 AM, Manuel Ebner wrote:
> OProfile has been discontinued as of commit 24880bef417f ("oprofile-removal")
>
> Suggested-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
> Reviewed-by: Bhaskar Chowdhury <unixbhaskar@xxxxxxxxx>
> Signed-off-by: Manuel Ebner <manuelebnerli@xxxxxxxxxxx>
Acked-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
Thanks.
> ---
> Bhaskar Chowdhury review doesn't show up in the mailing list, but I got it.
>
> [v2]
> fixed referenced commit
> + Suggested-by
> + Reviewed-by
>
> [v1]
> https://lore.kernel.org/all/20260830125506.632168-2-manuelebnerli@xxxxxxxxxxx/
>
> prior discussion
> https://lore.kernel.org/all/875527abdf9df0393ade872c6df3612ae9945b44.camel@xxxxxxxxxxx/
> ---
> arch/sparc/kernel/nmi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/sparc/kernel/nmi.c b/arch/sparc/kernel/nmi.c
> index 149adc094..1571d6298 100644
> --- a/arch/sparc/kernel/nmi.c
> +++ b/arch/sparc/kernel/nmi.c
> @@ -41,7 +41,7 @@ static int panic_on_timeout;
> * <0: the NMI watchdog has not been set up, and cannot be enabled
> * 0: the NMI watchdog is disabled, but can be enabled
> */
> -atomic_t nmi_active = ATOMIC_INIT(0); /* oprofile uses this */
> +atomic_t nmi_active = ATOMIC_INIT(0);
> EXPORT_SYMBOL(nmi_active);
> static int nmi_init_done;
> static unsigned int nmi_hz = HZ;
--
~Randy