[PATCH v2 3/6] ACPI: scan: Combine two conditionals in acpi_bus_attach()
From: Rafael J. Wysocki
Date: Wed Sep 02 2026 - 16:30:56 EST
From: "Rafael J. Wysocki" <rafael.j.wysocki@xxxxxxxxx>
There are two conditionals in acpi_bus_attach() that can be combined,
which slightly reduces the overhead and makes the code a bit easier
to follow, so do that.
No intentional functional impact.
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>
---
v1 -> v2:
* Reverse checks to avoid multiple negations (Andy)
* Rebase on top of the new [2/6]
Link to the v1:
https://lore.kernel.org/linux-pci/2021470.taCxCBeP46@rafael.j.wysocki/
---
drivers/acpi/scan.c | 9 ++-------
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a/drivers/acpi/scan.c b/drivers/acpi/scan.c
index 4586f1798685..7208cc515866 100644
--- a/drivers/acpi/scan.c
+++ b/drivers/acpi/scan.c
@@ -2370,13 +2370,8 @@ static int acpi_bus_attach(struct acpi_device *device, void *first_pass)
if (ret < 0)
return 0;
- if (ret > 0 && !device->flags.enumeration_by_parent) {
- acpi_device_set_enumerated(device);
- goto ok;
- }
-
- if (device->pnp.type.platform_id || device->pnp.type.backlight ||
- device->flags.enumeration_by_parent)
+ if (device->flags.enumeration_by_parent ||
+ (!ret && (device->pnp.type.platform_id || device->pnp.type.backlight)))
acpi_default_enumeration(device);
else
acpi_device_set_enumerated(device);
--
2.51.0