Re: [PATCH v2 1/2] nvme-tcp: refactor I/O queue setup path

[Surabhi Gogte (she/her)]

On Sun, Aug 30, 2026 at 2:56 PM Sagi Grimberg <sagi@xxxxxxxxxxx> wrote:
>
>
>
> On 25/08/2026 1:56, Surabhi Gogte wrote:
> > Split the I/O queue setup helpers apart so that the individual steps can
> > be called directly from nvme_tcp_configure_io_queues():
> >
> > - Queue count negotiation moves out of nvme_tcp_alloc_io_queues() into a
> >    new nvme_tcp_io_queue_count(), leaving the allocator with just the
> >    per-queue allocation loop.
> > - TLS PSK validation moves out of __nvme_tcp_alloc_io_queues() into a
> >    new nvme_tcp_tls_check_psk().
> > - nvme_tcp_configure_io_queues() now calls the three steps directly in
> >    the same order as before.
> >
> > Signed-off-by: Surabhi Gogte <sgogte@xxxxxxxxxxxxxxx>
> > ---


> >   }
> >
> > -static int nvme_tcp_alloc_io_queues(struct nvme_ctrl *ctrl)
> > +static int nvme_tcp_io_queue_count(struct nvme_ctrl *ctrl)
>
> Strange function name... maybe nvme_tcp_set_io_queue_count?

Yeah, that works better. will update in v3.