Re: [PATCH v3 2/2] net: pcs: rzn1-miic: Verify port number from dtb
From: Jakub Kicinski
Date: Wed Sep 02 2026 - 18:12:31 EST
On Wed, 02 Sep 2026 11:37:36 -0700 Kyle Hendry via B4 Relay wrote:
> + if (port < miic->of_data->miic_port_start || port > miic->of_data->miic_port_max) {
Please wrap this at 80 chars, some for previous patch
> + dev_err(miic->dev, "Port number out of range: %d\n", port);
> + kfree(dt_val);
> + return -EINVAL;
coccicheck says:
drivers/net/pcs/pcs-rzn1-miic.c:691:1-33: WARNING: Function "for_each_available_child_of_node" should have of_node_put() before return around line 698.
> + }
--
pw-bot: cr