Re: [PATCH] tools/firewire: nosy-dump: fix input file handle leak

[Takashi Sakamoto]

Hi,

On Wed, Sep 02, 2026 at 10:39:13AM +0800, longlong yan wrote:
> The input file handle opened via the --input option is leaked on
> multiple exit paths:
> 
> 1. When fopen() for the output file fails, the already-opened input
>    handle is not closed before returning.
> 
> 2. When fread() reaches EOF while reading from the input file, the
>    main loop returns directly, bypassing the cleanup section entirely.
> 
> 3. On normal exit (e.g., SIGINT), the cleanup section closes output
>    and fd but never closes input.
> 
> Fix this by closing the input handle on the output-fopen error path
> and in the cleanup section, and by changing the fread EOF early return
> to a break so that the cleanup section runs.
> 
> Signed-off-by: longlong yan <yanlonglong@xxxxxxxxxx>
> ---
>  tools/firewire/nosy-dump.c | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)

Applied to for-next branch.


Thanks

Takashi Sakamoto