Re: [PATCH v5 0/6] mm/mglru: clean up folio counters and flag usage

[Kairui Song]

On Thu, Sep 3, 2026 at 5:11 AM Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:
>
> On Wed, 02 Sep 2026 17:50:53 +0800 Kairui Song via B4 Relay <devnull+kasong.tencent.com@xxxxxxxxxx> wrote:
>
> > This is a cleanup series separated out from the MGLRU-FG series [1]. As
> > that series is getting too long in following updates, seperate out the
> > clean up part for easier review and merge.
> >
> > No feature change is intended, except one bugfix. It mostly replaces
> > the open-coded bit operations scattered throughout the MGLRU code with
> > new helpers, with proper kdocs, sanity debug checks, and hardens a few
> > MGLRU functions.
> >
> > A subtle generation counter leak is also found during the refactoring
> > and the fix is included.
> >
> > Also collected review feedbacks on the cleanup part from the posted
> > series.
>
> Thanks.  I hit a non-trivial reject in [2/6] presumably thanks to
> mm.git (mm-new) race conditions (appended).
>
> The patchset comes nicely review by humans, but AI is less happy:
>         https://sashiko.dev/#/patchset/20260902-mglru-flags-cleanup-v5-0-9db761d779ef@xxxxxxxxxxx
>
> So please take a look at all that and retry in a few days?

Right, I checked both already, sashiko has beem compalining about the
same issue again and again since V2:
https://lore.kernel.org/all/CAMgjq7BheDgQZa0=KiRnxVwky9by5LA=iaexfPfT0WftgfL=qQ@xxxxxxxxxxxxxx/

It's safe to ignore: not introduced by this series, and not a real
problem either.

The refs part is also fine, it barely has any real effect.

Should I just rebase on top of mm-new? I also saw Barry's rebased
version of Patch 2, that looks good to me.