[PATCH 3/3] kernfs: fix up the unlocked attribute reads on the creation paths

[Shakeel Butt]

Two creation paths read a live node's attributes without holding
kernfs_iattr_rwsem, which kernfs_iop_setattr() takes for writing.  They
do not want the same fix.

kernfs_create_link() copies the target's ia_uid and then its ia_gid
into the new link.  A chown of the target between the two reads leaves
the link with the old uid and the new gid, an owner the target never
had, when copying the target's owner is the whole point.  Read both
fields under the rwsem.

kernfs_new_node() reads the parent's ia_gid for S_ISGID inheritance,
and that one does not care which value it gets: the node does not exist
yet, so nothing orders a racing chown against the creation either way.
Taking the rwsem there would only serialize creation under a set-gid
parent against a chown of that parent, to pick between two answers that
are both right.  Mark the field read data_race() instead.

The pointer that leads to it is a different matter: __kernfs_iattrs()
publishes kernfs_node::iattr with try_cmpxchg(), so there is no
unmarked write for that read to pair with, and both sides read it with
READ_ONCE() like the rest of fs/kernfs does.

The Fixes tag is for the symlink half.  kernfs_create_link() has read
the pair without a lock since it started copying the target's owner at
all; only the name of the lock its writer takes has changed since.  The
data_race() is a marking rather than a fix.

Fixes: 488dee96bb62 ("kernfs: allow creating kernfs objects with arbitrary uid/gid")
Signed-off-by: Shakeel Butt <shakeel.butt@xxxxxxxxx>
---
 fs/kernfs/dir.c     | 16 +++++++++++++---
 fs/kernfs/symlink.c | 17 ++++++++++++++---
 2 files changed, 27 insertions(+), 6 deletions(-)

diff --git a/fs/kernfs/dir.c b/fs/kernfs/dir.c
index 214c97130a8a..3997c02f0165 100644
--- a/fs/kernfs/dir.c
+++ b/fs/kernfs/dir.c
@@ -740,9 +740,19 @@ struct kernfs_node *kernfs_new_node(struct kernfs_node *parent,
 		/* this code block imitates inode_init_owner() for
 		 * kernfs
 		 */
-
-		if (parent->iattr)
-			gid = parent->iattr->ia_gid;
+		struct kernfs_iattrs *attrs = READ_ONCE(parent->iattr);
+
+		if (attrs) {
+			/*
+			 * Unlocked on purpose: the gid is inherited onto a
+			 * node that does not exist yet, so nothing orders a
+			 * racing chown against this creation, and either
+			 * value is correct.  The pointer above needs no such
+			 * marking, __kernfs_iattrs() publishes it with
+			 * try_cmpxchg().
+			 */
+			gid = data_race(attrs->ia_gid);
+		}
 
 		if (flags & KERNFS_DIR)
 			mode |= S_ISGID;
diff --git a/fs/kernfs/symlink.c b/fs/kernfs/symlink.c
index 90e2b3221b83..3e53105d3abf 100644
--- a/fs/kernfs/symlink.c
+++ b/fs/kernfs/symlink.c
@@ -31,9 +31,20 @@ struct kernfs_node *kernfs_create_link(struct kernfs_node *parent,
 	kuid_t uid = GLOBAL_ROOT_UID;
 	kgid_t gid = GLOBAL_ROOT_GID;
 
-	if (target->iattr) {
-		uid = target->iattr->ia_uid;
-		gid = target->iattr->ia_gid;
+	/*
+	 * A symlink takes its owner from its target, so both fields have to
+	 * come from the same moment: read them under kernfs_iattr_rwsem, or
+	 * a chown of the target racing this could leave the link with the
+	 * old uid and the new gid.  The section ends before kernfs_add_one()
+	 * takes kernfs_rwsem.
+	 */
+	scoped_guard(rwsem_read, &kernfs_root(target)->kernfs_iattr_rwsem) {
+		struct kernfs_iattrs *attrs = READ_ONCE(target->iattr);
+
+		if (attrs) {
+			uid = attrs->ia_uid;
+			gid = attrs->ia_gid;
+		}
 	}
 
 	kn = kernfs_new_node(parent, name, S_IFLNK|0777, uid, gid, KERNFS_LINK);
-- 
2.53.0-Meta