Re: [PATCH RFC 0/4] Update imx678 to act as a common Sony Starvis 2 driver.

[Jai Luthra]

Hi Dave,

Thank you, I'm glad this turned out quite clean :-)

Quoting Dave Stevenson (2026-08-05 21:39:15)
> The IMX678 (8MPix) driver has been accepted.
> 
> Whilst preparing a patchset for IMX662 (1080p), I observed such
> commonality between the two that it seemed sensible to attempt
> a common driver rather than submitting a separate IMX662 series
> again.
> 
> On checking my box of sensors, I found I had an IMX675 (5MPix) as
> well, so that has been incorporated.
> 
> This set proposes a common driver that is working with all 3 of
> those sensors.
> It's sent as an RFC to gather confirmation that the resulting driver
> structure is acceptable as implied by [1].
> 

Overall structure looks good to me, I was able to stream with the Soho
IMX662 module I have.

> If it is viewed as acceptable then there is still a modest amount
> of tidying up required:
> - DT binding updates for the extra compatibles.
> - Rename the common functions so that the model references are
>   only on the model specific parts.
> - Add the Sony init sequence for IMX662.

I added most of the registers I could see were different from the default
values:
https://github.com/jailuthra/linux/commit/9ecb2d905581e9cf7ca61aa45c3b440fe7042307

Thanks,
    Jai

> - Check the init sequence for IMX675 (I'm waiting on a datasheet).
> - Update the 2 lane mode handling of HMAX. IMX662 can achieve the
>   same maximum framerate in 2 lane mode with a link freq of 594MHz
>   or greater, and I suspect others can do so too.
> - Hopefully add IMX585 (8MPix) to the supported list, and Jai has
>   mentioned IMX676 (12MPix) as well.
> 
> I wanted to confirm that there aren't any major objections before
> doing those cleanups though.
> 
> For anyone testing on a Pi, I've thrown a branch at [2] which includes
> overlays for each. I've tested with modules from Soho Enterprises,
> but there seem to be a few different vendors around.
> 
> [1] https://lore.kernel.org/linux-media/20260312150437.1091195-1-eagle.alexander923@xxxxxxxxx/T/#md6a186b4abd05fb035d020ce0bc562455ef5bed1
> [2] https://github.com/6by9/linux/tree/rpi-7.2.y-starvis
> 
> Signed-off-by: Dave Stevenson <dave.stevenson@xxxxxxxxxxxxxxx>
> ---
> Dave Stevenson (4):
>       media: i2c: imx678: Always program the sensor in window mode
>       media: i2c: imx678: Parameterise the configuration to allow for other models
>       media: i2c: imx678: Add imx662 support to the driver
>       media: i2c: imx678: Add imx675 support to the driver
> 
>  drivers/media/i2c/imx678.c | 451 +++++++++++++++++++++++++++++++++++++++------
>  1 file changed, 393 insertions(+), 58 deletions(-)
> ---
> base-commit: 31152f5b0f8719f92063b8c6196cd5e34106c73d
> change-id: 20260804-media-starvis2-65a5bc405b74
> 
> Best regards,
> -- 
> Dave Stevenson <dave.stevenson@xxxxxxxxxxxxxxx>
>