Re: [PATCH RFC 1/4] media: i2c: imx678: Always program the sensor in window mode

[Jai Luthra]

Quoting Dave Stevenson (2026-08-05 21:39:16)
> If the requested region matched the defined active area then
> the driver switched to all-pixel mode. This left the possibilty
> that the activeare was incorrect and not reading out the area
> expected.
> 
> Switch to always requesting window mode.
> 
> Signed-off-by: Dave Stevenson <dave.stevenson@xxxxxxxxxxxxxxx>

Reviewed-by: Jai Luthra <jai.luthra@xxxxxxxxxxxxxxxx>

> ---
>  drivers/media/i2c/imx678.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/media/i2c/imx678.c b/drivers/media/i2c/imx678.c
> index 0efbf43d2fe6..f7b988dca2ac 100644
> --- a/drivers/media/i2c/imx678.c
> +++ b/drivers/media/i2c/imx678.c
> @@ -917,9 +917,7 @@ static int imx678_program_window(struct imx678 *imx678,
>         int ret = 0;
>  
>         cci_write(imx678->cci, IMX678_REG_ADDMODE, 0x00, &ret);
> -       cci_write(imx678->cci, IMX678_REG_WINMODE,
> -                 v4l2_rect_equal(crop, &imx678_active_area) ? 0x00 : 0x04,
> -                 &ret);
> +       cci_write(imx678->cci, IMX678_REG_WINMODE, 0x04, &ret);
>         cci_write(imx678->cci, IMX678_REG_PIX_HST,
>                   crop->left - imx678_active_area.left, &ret);
>         cci_write(imx678->cci, IMX678_REG_PIX_HWIDTH, crop->width, &ret);
> 
> -- 
> 2.34.1
>