Re: [PATCH v6 14/16] media: atomisp: Use struct v4l2_area for padding

[Andy Shevchenko]

On Tue, Sep 01, 2026 at 09:04:36PM +0200, Maurizio Casciano wrote:
> The padding helper passes width and height as four separate scalar
> arguments even though they form two logical dimensions.
> 
> Pass the requested size and returned padding as struct v4l2_area values.
> This makes the dimensions explicit and simplifies all three callers.

Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxx>

...

>  	dev_dbg(isp->dev, "s_mbus_fmt: ask %ux%u (padding %ux%u, dvs %ux%u)\n",
> -		ffmt.width, ffmt.height, asd->sink_pad_padding_w, asd->sink_pad_padding_h,

> +		ffmt.width, ffmt.height, asd->sink_pad_padding.width,
> +		asd->sink_pad_padding.height,

Split logically

		ffmt.width, ffmt.height,
		asd->sink_pad_padding.width, asd->sink_pad_padding.height,

>  		dvs_env_w, dvs_env_h);

-- 
With Best Regards,
Andy Shevchenko