Re: [PATCH v7 00/16] media: Add Yoga Book camera support

From: Andy Shevchenko

Date: Thu Sep 03 2026 - 01:41:46 EST


On Thu, Sep 03, 2026 at 07:44:30AM +0300, Andy Shevchenko wrote:
> On Wed, Sep 02, 2026 at 04:53:29PM +0200, Maurizio Casciano wrote:
> >
> > This series adds the sensor, bridge, AtomISP and lens-actuator support
> > needed by the front and rear cameras of the Lenovo Yoga Book YB1-X91.
> >
> > It covers the OV8858 19.2 MHz clock and Cherry Trail gain programming,
> > OV2740 288 MHz link frequency and manual white balance, firmware IDs and
> > IPU bridge data, AtomISP raw capture and CSI-2 timing, and the WV517S lens
> > actuator.
>
> > Changes in v7:
> > - In patch 2, keep digital gain independent of the external clock and
> > expose the manual red and blue gains as separate controls, as requested
> > by Sakari Ailus. Keep green at unity and accumulate register-write
> > errors across the three manual white-balance channels.
> > - Move the 24 MHz PLL and global timing registers out of the common mode
> > tables into revision- and lane-specific arrays. Select both 19.2 MHz and
> > 24 MHz clock programming explicitly when starting a stream.
> > - Clarify the patch 2 assistance disclosure as
> > `Assisted-by: LLM [Codex] [Sparse]`.
> > - No changes to patches 1 and 3 through 16.
>
> Wait at least a few days before sending a new version.
>
> There will be a v8 as far as I can tell, but send it next week after all comments
> were addressed (or settled down).

To collect given tags use `b4` tool.

And general comment about AI, try to do some work yourself, AI does not
guarantee 100% correct results.

--
With Best Regards,
Andy Shevchenko