Re: [PATCH v1 03/13] iio: adc: ad4134: Update include list to comply with IWYU principles
From: Andy Shevchenko
Date: Thu Sep 03 2026 - 02:27:03 EST
On Wed, Sep 02, 2026 at 02:22:16PM -0300, Marcelo Schmitt wrote:
> Add includes that were missing (according to include-what-you-use tool)
> to comply with include what is used principles. Namely, add bits.h for
> BIT and GENMASK, and time64.h for USEC_PER_SEC.
>
> Remove time.h which is covered by time64.h and iio/types.h which is
> covered by iio/iio.h.
>
> While updating the list, organize it to follow current IIO include list
> convention.
...
> @@ -7,6 +7,7 @@
> #include <linux/array_size.h>
> #include <linux/bitfield.h>
> #include <linux/bitops.h>
> +#include <linux/bits.h>
No need, bitops.h implies it.
...
With that being addressed
Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxx>
--
With Best Regards,
Andy Shevchenko