Re: [PATCH v2 3/3] btrfs: promote async checksumming out of EXPERIMENTAL

[Qu Wenruo]

在 2026/9/3 15:53, Daniel Vacek 写道:
> There was no issue with this feature since it's introduction in
> dd57c78aec398 ("btrfs: introduce btrfs_bio::async_csum").
> No need for hiding it.
>
> Signed-off-by: Daniel Vacek <neelx@xxxxxxxx>

Oh, I was doing this already, and it turns out that we have a lot of 
things to cleanup:

---
 fs/btrfs/bio.c       | 136 +------------------------------------------
 fs/btrfs/disk-io.c   |  20 +------
 fs/btrfs/file-item.c |   6 +-
 fs/btrfs/file-item.h |   2 +-
 fs/btrfs/fs.h        |  10 ----
 fs/btrfs/super.c     |   1 -
 6 files changed, 4 insertions(+), 171 deletions(-)

The main missing part is the should_async_write() now always return 
false (you missed that EXPERIMENTAL flag there).

Then it means the whole async submission part is no longer required, 
resulting the above code removal.

Thanks,
Qu


> ---
>
> v2: Introduced this change.
> ---
>   fs/btrfs/bio.c | 4 ----
>   1 file changed, 4 deletions(-)
>
> diff --git a/fs/btrfs/bio.c b/fs/btrfs/bio.c
> index 771b7d598aee..db426ee6e587 100644
> --- a/fs/btrfs/bio.c
> +++ b/fs/btrfs/bio.c
> @@ -569,11 +569,7 @@ static int btrfs_bio_csum(struct btrfs_bio *bbio)
>   {
>   	if (bbio->bio.bi_opf & REQ_META)
>   		return btree_csum_one_bio(bbio);
> -#ifdef CONFIG_BTRFS_EXPERIMENTAL
>   	return btrfs_csum_one_bio(bbio, true);
> -#else
> -	return btrfs_csum_one_bio(bbio, false);
> -#endif
>   }
>   
>   /*