Re: [PATCH v2 2/2] mm/mglru: make retry logic explicit in isolate_folios()

[Barry Song (Xiaomi)]

On Thu, Sep 3, 2026 at 9:27 AM Baoquan He <baoquan.he@xxxxxxxxx> wrote:
>
[...]
>
> Thanks, Barry. These number is very convincing. The retry for swappiness
> 0 is worthy. Then the patchset feels like doing two things: refactoring
> the for() loop; improving the eviction for swappiness 0/201 by adding a
> retry and this also makes them be consistent with (1, 200). While the
> cover letter subject, patch 1 and patch 2 feels like it's not easy to
> match them to the corresponding part. Maybe merging them to one patch,
> or rearranging them? Just personal opinion.
>

Hi Baoquan,

Thanks very much for your suggestions and review.
We have two patches:

1. `mm/mglru: make type fallback logic explicit in isolate_folios()`
2. `mm/mglru: make retry logic explicit in isolate_folios()`

One handles fallback, while the other handles retry. I think this
separation makes the logic clearer. Could we keep the current
separation?

But we may really need Andrew's kind help to squash the change
you found below: