Re: [PATCH] iio: light: apds9306: fix default sampling frequency definition

[Tsz Shan Chan]

On Thu, Sep 03, 2026 at 09:41:27AM +0300, Andy Shevchenko wrote:
> On Thu, Sep 03, 2026 at 03:38:47PM +1000, Tsz Shan Chan wrote:
> > APDS9306_SAMP_FREQ_10HZ is defined as 0.
> > 
> > According to the datasheet (page 11, ALS_MEAS_RATE), bits[2:0] set the
> 
> Can you add a Datasheet link? (Or at least the version and name)
> 
> > measurement rate:
> > - 000: 25ms  (40Hz)
> > - 001: 20ms  (20Hz)
> > - 010: 100ms (10Hz)
> > 
> > Change APDS9306_SAMP_FREQ_10HZ from 0 to 2 to write the correct value
> > for 10Hz.
> 
> > Fixes: 620d1e6c7a3f ("iio: light: Add support for APDS9306 Light Sensor")
> > 
> > Signed-off-by: Tsz Shan Chan <tchan@xxxxxxxxxxxxxx>
> 
> No blank lines in the tag block (at the end of the commit message).

I'll add the datasheet link and remove the blank line in v2 commit
message. Thanks.