[PATCH 4/4] rtc: test: Remove test_rtc_lib.c

From: Thomas Weißschuh (Schneider Electric)

Date: Thu Sep 03 2026 - 03:59:21 EST


Now that rtc_time64_to_tm() is only a thin wrapper around time64_to_tm()
the dedicated test is not necessary anymore. time64_to_tm() is already
tested with a similar test in kernel/time/time_test.c

Remove it.

Signed-off-by: Thomas Weißschuh (Schneider Electric) <thomas.weissschuh@xxxxxxxxxxxxx>
---
drivers/rtc/Kconfig | 9 ----
drivers/rtc/Makefile | 2 -
drivers/rtc/test_rtc_lib.c | 106 ---------------------------------------------
3 files changed, 117 deletions(-)

diff --git a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig
index 05b9233b9418..b507ed2f10e7 100644
--- a/drivers/rtc/Kconfig
+++ b/drivers/rtc/Kconfig
@@ -75,15 +75,6 @@ config RTC_DEBUG
Say yes here to enable debugging support in the RTC framework
and individual RTC drivers.

-config RTC_LIB_KUNIT_TEST
- tristate "KUnit test for RTC lib functions" if !KUNIT_ALL_TESTS
- depends on KUNIT
- default KUNIT_ALL_TESTS
- help
- Enable this option to test RTC library functions.
-
- If unsure, say N.
-
config RTC_NVMEM
bool "RTC non volatile storage support"
select NVMEM
diff --git a/drivers/rtc/Makefile b/drivers/rtc/Makefile
index 0347645b021f..a3b336432df1 100644
--- a/drivers/rtc/Makefile
+++ b/drivers/rtc/Makefile
@@ -15,8 +15,6 @@ rtc-core-$(CONFIG_RTC_INTF_DEV) += dev.o
rtc-core-$(CONFIG_RTC_INTF_PROC) += proc.o
rtc-core-$(CONFIG_RTC_INTF_SYSFS) += sysfs.o

-obj-$(CONFIG_RTC_LIB_KUNIT_TEST) += test_rtc_lib.o
-
# Keep the list ordered.

obj-$(CONFIG_RTC_DRV_88PM80X) += rtc-88pm80x.o
diff --git a/drivers/rtc/test_rtc_lib.c b/drivers/rtc/test_rtc_lib.c
deleted file mode 100644
index 0eebad1fe2a0..000000000000
--- a/drivers/rtc/test_rtc_lib.c
+++ /dev/null
@@ -1,106 +0,0 @@
-// SPDX-License-Identifier: LGPL-2.1+
-
-#include <kunit/test.h>
-#include <linux/rtc.h>
-
-/*
- * Advance a date by one day.
- */
-static void advance_date(int *year, int *month, int *mday, int *yday, int *wday)
-{
- *wday = (*wday + 1) % 7;
-
- if (*mday != rtc_month_days(*month - 1, *year)) {
- ++*mday;
- ++*yday;
- return;
- }
-
- *mday = 1;
- if (*month != 12) {
- ++*month;
- ++*yday;
- return;
- }
-
- *month = 1;
- *yday = 1;
- ++*year;
-}
-
-/*
- * Check every day in specified number of years interval starting on 1970-01-01
- * against the expected result.
- */
-static void rtc_time64_to_tm_test_date_range(struct kunit *test, int years)
-{
- /*
- * years = (years / 400) * 400 years
- * = (years / 400) * 146097 days
- * = (years / 400) * 146097 * 86400 seconds
- */
- time64_t total_secs = ((time64_t)years) / 400 * 146097 * 86400;
-
- int year = 1900;
- int month = 1;
- int mday = 1;
- int yday = 1;
- int wday = 1; /* Jan 1st 1900 was a Monday */
-
- struct rtc_time result;
- time64_t secs;
- const time64_t sec_offset = RTC_TIMESTAMP_BEGIN_1900 + ((1 * 60) + 2) * 60 + 3;
-
- for (secs = 0; secs <= total_secs; secs += 86400) {
-
- rtc_time64_to_tm(secs + sec_offset, &result);
-
- #define FAIL_MSG "%d/%02d/%02d (%2d, %d) : %lld", \
- year, month, mday, yday, wday, secs + sec_offset
-
- KUNIT_ASSERT_EQ_MSG(test, year - 1900, result.tm_year, FAIL_MSG);
- KUNIT_ASSERT_EQ_MSG(test, month - 1, result.tm_mon, FAIL_MSG);
- KUNIT_ASSERT_EQ_MSG(test, mday, result.tm_mday, FAIL_MSG);
- KUNIT_ASSERT_EQ_MSG(test, yday, result.tm_yday, FAIL_MSG);
- KUNIT_ASSERT_EQ_MSG(test, 1, result.tm_hour, FAIL_MSG);
- KUNIT_ASSERT_EQ_MSG(test, 2, result.tm_min, FAIL_MSG);
- KUNIT_ASSERT_EQ_MSG(test, 3, result.tm_sec, FAIL_MSG);
- KUNIT_ASSERT_EQ_MSG(test, wday, result.tm_wday, FAIL_MSG);
-
- advance_date(&year, &month, &mday, &yday, &wday);
- }
-}
-
-/*
- * Checks every day in a 160000 years interval starting on 1900-01-01
- * against the expected result.
- */
-static void rtc_time64_to_tm_test_date_range_160000(struct kunit *test)
-{
- rtc_time64_to_tm_test_date_range(test, 160000);
-}
-
-/*
- * Checks every day in a 1000 years interval starting on 1900-01-01
- * against the expected result.
- */
-static void rtc_time64_to_tm_test_date_range_1000(struct kunit *test)
-{
- rtc_time64_to_tm_test_date_range(test, 1000);
-}
-
-static struct kunit_case rtc_lib_test_cases[] = {
- KUNIT_CASE(rtc_time64_to_tm_test_date_range_1000),
- KUNIT_CASE_SLOW(rtc_time64_to_tm_test_date_range_160000),
- {}
-};
-
-static struct kunit_suite rtc_lib_test_suite = {
- .name = "rtc_lib_test_cases",
- .test_cases = rtc_lib_test_cases,
-};
-
-kunit_test_suite(rtc_lib_test_suite);
-
-MODULE_DESCRIPTION("KUnit test for RTC lib functions");
-MODULE_LICENSE("GPL");

--
2.55.0