Re: [PATCH v4 2/3] gpiolib: add get_config() and gpiochip_generic_get_config()
From: Mehmet Fide
Date: Thu Sep 03 2026 - 04:10:54 EST
From: Mehmet Fide <mehmet.fide@xxxxxxxxxxxxxxxxxx>
> [Severity: Medium]
> Does pinctrl_gpio_get_config() actually return a packed answer?
>
> Looking at drivers/pinctrl/core.c, pinctrl_gpio_get_config() intentionally
> strips the parameter and returns only the unpacked argument:
It does not, you are right, and the documentation I wrote is wrong: the
packed parameter goes in and the bare argument comes out, exactly what
pinctrl_gpio_get_config() does, and what gpio-mmio relies on in patch 3.
The code is fine, the kernel-doc in driver.h and gpiolib.c and the
driver.rst paragraph are not. v5 fixes the three texts; no code change.
Mehmet