Re: [PATCH 6/6] arm64: dts: qcom: Add initial support for Nord Ride Embedded board

[Konrad Dybcio]

On 9/3/26 10:13 AM, Shawn Guo wrote:
> On Thu, Sep 03, 2026 at 09:56:16AM +0200, Konrad Dybcio wrote:
>> On 9/3/26 9:40 AM, Shawn Guo wrote:
>>> On Wed, Sep 02, 2026 at 04:00:52PM +0200, Konrad Dybcio wrote:
>>>> On 8/31/26 5:21 AM, Shawn Guo wrote:
>>>>> From: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxxxxxxxx>
>>>>>
>>>>> Add the initial device tree for the Nord Ride Embedded board, the
>>>>> non-SCMI variant of the SA8797P automotive Ride board.
>>
>> [...]
>>
>>> Since we agreed that a bit comment is useful [1], I guess you are saying
>>> the "satellite (CD90-73961-1)" part shouldn't be there. I will get the
>>> comment aligned with nord-rrd.dts.
>>
>> Ah I forgot I said that :)
>>
>> [...]
>>
>>>>> +		vreg_s7i_mm: smps7 {
>>>>> +			regulator-name = "vreg_s7i_mm";
>>>>> +			regulator-min-microvolt = <300000>;
>>>>> +			regulator-max-microvolt = <1200000>;
>>>>> +			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
>>>>> +			regulator-allow-set-load;
>>>>> +			regulator-allowed-modes = <RPMH_REGULATOR_MODE_LPM
>>>>> +						   RPMH_REGULATOR_MODE_HPM>;
>>>>
>>>> Are these actually exposed as regulators and not RPMHPDs?
>>>
>>> Great catch, Konrad! These are rpmhpd-managed resources and shouldn't be
>>> here. I will drop them.
>>
>> Don't you get a huge log of errors with these in place?
> 
> Nope. If we do, we must have already fixed the problem :)

Indeed, the cmd-db you posted [1] allows accessing both at once.. I'm
not sure this is intended..

Konrad

[1] https://lore.kernel.org/linux-arm-msm/ao7mrrW_ob77EAIp@QCOM-aGQu4IUr3Y/