Re: [PATCH v19 02/14] cxl/ras: Fix cxl_rch_get_aer_severity() wrong severity register

[Lukas Wunner]

Hi Terry,

You've submitted v20 of this series, but the following
questions haven't been addressed yet AFAICS.  I'd be
grateful if you could take a look:

On Sun, Aug 09, 2026 at 05:57:23PM +0200, Lukas Wunner wrote:
> Am I missing something?  Is a scenario ever conceivable where the RCEC
> receives a message with different severity than what is inferred from
> the registers by cxl_rch_get_aer_severity()?
[...]
> These so-called Advisory Non-Fatal Errors set one bit in the Correctable
> Error Status Register (Advisory Non-Fatal Error Status, bit 13) and
> additionally one or more bits in the Uncorrectable Error Status Register
> (see the commit for details).
> 
> cxl_rch_get_aer_severity() is not able to cope with such errors and
> will incorrectly infer that the severity is AER_NONFATAL.
> 
> Now I *think* this is not a problem because Advisory Non-Fatal Errors
> are masked by default and the commit only unmasks them on regular PCI
> devices, not in the RCRB of a CXL device.  Only once bit 13 in the
> Correctable Error Mask Register is cleared in the RCRB will
> cxl_rch_get_aer_severity() fail.  Right?

Thanks,

Lukas