Re: [PATCH v2] docs: verify/bisect: fix typos

[Thorsten Leemhuis]

On 9/3/26 10:22, Manuel Ebner wrote:
> On Wed, 2026-09-02 at 18:30 +0200, Thorsten Leemhuis wrote:
>> On 9/2/26 13:51, Manuel Ebner wrote:

>> For typos and grammar fixes there is not much to say, so maybe just
>> state that; but you might want to look at a few recent changes in
>> Documentation/ to see how other developers approach a situation like this.
> 
> That's a good idea. I did only find slightly more verbose than mine, eg:
>> Fix 'hay attention' -> 'pay attention' in file.rst
> or
>> Replace "an a few" with "and a few" in
>> Documentation/driver-api/media/drivers/zoran.rst.

Yeah, maybe that slipped thought; and if it's just one or two fixes
okayish, but after that a vague "Fix a few typos/mistakes/grammer
issues" becomes better I'd say, unless there is something more to tell.
Hopefully Jonathan agrees with this.
>>> @@ -178,8 +178,8 @@ will be considered the 'good' release and used to prepare the .config file.
>>>         ./scripts/config --set-str CONFIG_LOCALVERSION '-local-cafec0cacaca0-reverted'
>>>  
>>>      This is optional, as some commits are impossible to revert. But if the
>>> -    second command worked flawlessly, build, install, and boot one more kernel
>>> -    kernel; just this time skip the first command copying the base .config file
>>> +    second command worked flawlessly, build, install, and boot one more kernel;
>>> +    just this time skip the first command copying the base .config file
>>>      over, as that already has been taken care off.
>>
>> I'd move the "over, " to the previous line, as the formatting otherwise
>> looks odd. Not strictly required and makes the patch slightly more
>> complex (so might not be the best idea, but I think it's worth when it's
>> just one line).
> 
> I'd do the same, prior feedback taught me otherwise. I'll do it.

Yeah, that's somewhat a matter of personal preference and for me also a
case by case decision. In this case I think it's fine to change, as the
line break makes the para look somewhat odd. Also it's just one more
line that is changed -- if it were ten, I would have left it as it is.

Ciao, Thorsten