Re: [PATCH] staging: most: video: document the locks in struct most_video_dev
From: Greg KH
Date: Thu Sep 03 2026 - 05:20:38 EST
On Tue, Sep 01, 2026 at 08:20:55PM +0300, Godana Emiru wrote:
> Neither lock in struct most_video_dev carries a comment describing what
> it protects.
>
> list_lock protects the pending_mbos list. Buffers are added by the
> component's rx_completion callback, comp_rx_data(), which is invoked
> from the interface driver's completion path (a URB completion handler
> in the case of the USB HDM), and are removed from process context by
> comp_vdev_read() and comp_vdev_close(). Note that in the comment, since
> it is what makes the irq-safe spinlock variants necessary here.
>
> lock is never acquired by this driver directly. comp_register_videodev()
> installs it as struct video_device::lock, where v4l2_ioctl_get_lock()
> returns it and video_ioctl2() holds it across ioctl dispatch.
What tool did you use to generate this changelog?
thanks,
greg k-h