Re: [PATCH 2/4] char: xillybus: replace __get_free_pages() with kmalloc()

[Mike Rapoport]

On Wed, Sep 02, 2026 at 01:40:21PM +0200, Eli Billauer wrote:
> On 01/09/2026 19:24, Mike Rapoport wrote:
> > On Tue, Sep 01, 2026 at 10:42:47AM +0200, Eli Billauer wrote:
> > > On 31/08/2026 13:32, Mike Rapoport wrote:
> > > > For large sizes kmalloc falls back to page allocator anyway.
> > > > 
> > > > And the doc is out of date unfortunately.
> > > I think it would be a good idea to update the doc first, and by doing so
> > > officially change the API. After getting this change approved, it's indeed
> > > safe to rely on kmalloc() even for larger memory allocations.
> > The documentation always lags behind the code and "official" API is what
> > include/linux/slab.h says :)
> 
> This is what I found in slab.h:
> 
>  *
>  * kmalloc is the normal method of allocating memory
>  * for objects smaller than page size in the kernel.
>  *

Citing vbabka:

that sentence doesn't exclude >PAGE_SIZE allocations :)
 
> Regards,
>    Eli
> 

-- 
Sincerely yours,
Mike.