Re: [PATCH v2 2/2] rpmsg: glink: Request the RX interrupt already enabled
From: Konrad Dybcio
Date: Thu Sep 03 2026 - 07:06:25 EST
On 8/24/26 9:05 AM, Chunkai Deng wrote:
> The receive interrupt is requested masked early in probe and enabled
> further down, once the glink instance has been stored in the transport.
> Now that the version command is no longer sent from
> qcom_glink_native_probe(), nothing needs to happen between those two
> points.
>
> Request the interrupt where it used to be enabled, and drop
> IRQF_NO_AUTOEN along with the enable_irq() call. The RPM error path
> becomes a set of labels, the way SMEM already unwinds.
>
> Signed-off-by: Chunkai Deng <chunkai.deng@xxxxxxxxxxxxxxxx>
> Assisted-by: Claude:claude-opus-5
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx>
Konrad