Re: [PATCH RFC 0/4] Update imx678 to act as a common Sony Starvis 2 driver.

[Jai Luthra]

Quoting Dave Stevenson (2026-09-03 17:25:42)
> Hi Jai
> 
> Thanks for looking at the series.
> 
> On Thu, 3 Sept 2026 at 05:13, Jai Luthra <jai.luthra@xxxxxxxxxxxxxxxx> wrote:
> >
> > Hi Dave,
> >
> > Thank you, I'm glad this turned out quite clean :-)
> >
> > Quoting Dave Stevenson (2026-08-05 21:39:15)
> > > The IMX678 (8MPix) driver has been accepted.
> > >
> > > Whilst preparing a patchset for IMX662 (1080p), I observed such
> > > commonality between the two that it seemed sensible to attempt
> > > a common driver rather than submitting a separate IMX662 series
> > > again.
> > >
> > > On checking my box of sensors, I found I had an IMX675 (5MPix) as
> > > well, so that has been incorporated.
> > >
> > > This set proposes a common driver that is working with all 3 of
> > > those sensors.
> > > It's sent as an RFC to gather confirmation that the resulting driver
> > > structure is acceptable as implied by [1].
> > >
> >
> > Overall structure looks good to me, I was able to stream with the Soho
> > IMX662 module I have.
> >
> > > If it is viewed as acceptable then there is still a modest amount
> > > of tidying up required:
> > > - DT binding updates for the extra compatibles.
> > > - Rename the common functions so that the model references are
> > >   only on the model specific parts.
> > > - Add the Sony init sequence for IMX662.
> >
> > I added most of the registers I could see were different from the default
> > values:
> > https://github.com/jailuthra/linux/commit/9ecb2d905581e9cf7ca61aa45c3b440fe7042307
> 
> I just hadn't had the time to analyse the Sony docs when I sent the
> first stab. I've now done so from their magic spreadsheet, so
> hopefully our values match.
> 
> I've now got docs for all of them from Sony, so will check through them.
> And I've just been told IMX832 (new 2MPix) also matches this scheme,
> so that'll be another variant.
> 
> If you're on board with this, I'll do a wholesale replacement of
> imx678 with starvis2 in common defines, function names, and the file
> to starvis2.c as a first patch?
> 

Sounds good, thank you!

Jai