Re: [PATCH 1/7] media: i2c: vd55g: move patch array to a separate firmware header

[Krzysztof Kozlowski]

On Wed, Sep 02, 2026 at 04:45:40PM -0400, Peter Marshall wrote:
> A firmware patch consisting of an array of bytes is uploaded to the chip
> during its boot sequence. Declutter the driver source by moving it to a
> separate header file.
> 
> Signed-off-by: Peter Marshall <pm@xxxxxxxxxxxxxxxx>
> ---
>  drivers/media/i2c/vd55g-fw.h | 305 +++++++++++++++++++++++++++++++++++
>  drivers/media/i2c/vd55g1.c   | 296 +--------------------------------
>  2 files changed, 306 insertions(+), 295 deletions(-)
>  create mode 100644 drivers/media/i2c/vd55g-fw.h
> 
> diff --git a/drivers/media/i2c/vd55g-fw.h b/drivers/media/i2c/vd55g-fw.h
> new file mode 100644
> index 000000000..02faed7e4
> --- /dev/null
> +++ b/drivers/media/i2c/vd55g-fw.h
> @@ -0,0 +1,305 @@
> +/* SPDX-License-Identifier: GPL-2.0
> + *
> + * Driver for VD55G1 global shutter sensor family driver
> + *
> + * Copyright (C) 2025 STMicroelectronics SA
> + */
> +
> +#include <linux/kernel.h>
> +#include <linux/types.h>
> +
> +static const u8 vd55g1_patch_array[] = {

Headers should have data, because this can easily lead to duplicated
objects.

static arrays go to C units.

Best regards,
Krzysztof