Re: [PATCH 2/7] dt-bindings: media: i2c: st,vd55g: rename and add VD55G0 variant

[Krzysztof Kozlowski]

On Wed, Sep 02, 2026 at 04:45:41PM -0400, Peter Marshall wrote:
> Document the STMicroelectronics VD55G0 camera sensor. Rename the device
> tree bindings to represent a generic VD55G family sensor.

Renaming is not really needed. The binding should be named after
fallback or one of compatibles, usually.

> 
> Signed-off-by: Peter Marshall <pm@xxxxxxxxxxxxxxxx>
> ---
>  .../i2c/{st,vd55g1.yaml => st,vd55g.yaml}     | 30 +++++++++++++++----
>  1 file changed, 24 insertions(+), 6 deletions(-)
>  rename Documentation/devicetree/bindings/media/i2c/{st,vd55g1.yaml => st,vd55g.yaml} (76%)
> 
> diff --git a/Documentation/devicetree/bindings/media/i2c/st,vd55g1.yaml b/Documentation/devicetree/bindings/media/i2c/st,vd55g.yaml
> similarity index 76%
> rename from Documentation/devicetree/bindings/media/i2c/st,vd55g1.yaml
> rename to Documentation/devicetree/bindings/media/i2c/st,vd55g.yaml
> index 060ac6829..bd6feeb6c 100644
> --- a/Documentation/devicetree/bindings/media/i2c/st,vd55g1.yaml
> +++ b/Documentation/devicetree/bindings/media/i2c/st,vd55g.yaml
> @@ -2,19 +2,21 @@
>  # Copyright (c) 2025 STMicroelectronics SA.
>  %YAML 1.2
>  ---
> -$id: http://devicetree.org/schemas/media/i2c/st,vd55g1.yaml#
> +$id: http://devicetree.org/schemas/media/i2c/st,vd55g.yaml#
>  $schema: http://devicetree.org/meta-schemas/core.yaml#
>  
> -title: STMicroelectronics VD55G1 Global Shutter Image Sensor
> +title: STMicroelectronics VD55G Family Global Shutter Image Sensors
>  
>  maintainers:
>    - Benjamin Mugnier <benjamin.mugnier@xxxxxxxxxxx>
>    - Sylvain Petinot <sylvain.petinot@xxxxxxxxxxx>
> +  - Peter Marshall <pm@xxxxxxxxxxxxxxxx>
>  
>  description: |-
> - The STMicroelectronics VD55G1 is a global shutter image sensor with an active
> - array size of 804H x 704V. It is programmable through I2C interface. The I2C
> - address is fixed to 0x10.
> + The STMicroelectronics VD55G family (VD55G0, VD55G1, and VD65G4) consists of
> + global shutter image sensors. The VD55G0 has an array size of 644H x 604V.
> + The VD55G1 and VD65G4 have an array size of 804H x 704V. They are programmable
> + through I2C interface. The I2C address is fixed to 0x10.
>  
>   Image data is sent through MIPI CSI-2, which is configured as only 1 data
>   lane. The sensor provides 4 GPIOS that can be used for external LED signal
> @@ -23,13 +25,29 @@ description: |-
>  allOf:
>    - $ref: /schemas/media/video-interface-devices.yaml#
>  

Please move entire allOf to the bottom, before
additional/unevaluatedProperties, like in example-schema.

> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            const: st,vd55g0
> +    then:
> +      properties:
> +        port:
> +          properties:
> +            endpoint:
> +              properties:
> +                link-frequencies:
> +                  items:
> +                    minimum: 375000000

Best regards,
Krzysztof