Re: [PATCH] Documentation/gpu: Fix brackets

[Randy Dunlap]

Hi,

On 9/3/26 9:10 AM, Manuel Ebner wrote:
> Remove needless '(' and add missing ')'.
> 
> Signed-off-by: Manuel Ebner <manuelebnerli@xxxxxxxxxxx>
> ---
>  Documentation/gpu/drm-vm-bind-locking.rst | 2 +-
>  Documentation/gpu/nova/core/todo.rst      | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)

This patch probably should be 2 patches since these files have
different maintainers.


> diff --git a/Documentation/gpu/drm-vm-bind-locking.rst b/Documentation/gpu/drm-vm-bind-locking.rst
> index a345aa513..df6cf0132 100644
> --- a/Documentation/gpu/drm-vm-bind-locking.rst
> +++ b/Documentation/gpu/drm-vm-bind-locking.rst
> @@ -170,7 +170,7 @@ submission is therefore preceded with a re-validation section:
>             validate_gem_bo(&gpu_vm_bo->gem_bo);
>  
>             // The following list iteration needs the Gem object's
> -           // dma_resv to be held (it protects the gpu_vm_bo's list of
> +           // dma_resv to be held. It protects the gpu_vm_bo's list of
>             // gpu_vmas, but since local gem objects share the gpu_vm's
>             // dma_resv, it is already held at this point.

I think that I must like parenthetical phrases more than you do. ;)

Acked-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
Thanks.

>             for_each_gpu_vma_of_gpu_vm_bo(&gpu_vm_bo, &gpu_vma)
> diff --git a/Documentation/gpu/nova/core/todo.rst b/Documentation/gpu/nova/core/todo.rst
> index d5130b2b0..a01c362b1 100644
> --- a/Documentation/gpu/nova/core/todo.rst
> +++ b/Documentation/gpu/nova/core/todo.rst
> @@ -33,7 +33,7 @@ A good example from nova-core would be the ``Chipset`` enum type, which defines
>  the value ``AD102``. When probing the GPU the value ``0x192`` can be read from a
>  certain register indication the chipset AD102. Hence, the enum value ``AD102``
>  should be derived from the number ``0x192``. Currently, nova-core uses a custom
> -implementation (``Chipset::from_u32`` for this.
> +implementation (``Chipset::from_u32``) for this.
>  
>  Instead, it would be desirable to have something like the ``FromPrimitive``
>  trait [1] from the num crate.

-- 
~Randy