Re: [v26,net-next,01/10] net/nebula-matrix: add minimum nbl build framework

[netdev-bot+sashiko]

Thank you for your contribution! Sashiko AI review found 1 potential
issue(s) to consider:

Critical: 0 · High: 0 · Medium: 0 · Low: 1

- [Low] The documentation file added by this patch,
  Documentation/networking/device_drivers/ethernet/nebula-matrix/nbl.rst…

--

net/nebula-matrix: add minimum nbl build framework

This adds the Kconfig/Makefile/MAINTAINERS entries for a new
drivers/net/ethernet/nebula-matrix/ vendor directory, a driver
documentation file, and a PCI driver skeleton (nbl_main.c) whose probe
and remove callbacks are stubs.

> diff --git a/Documentation/networking/device_drivers/ethernet/nebula-matrix/nbl.rst b/Documentation/networking/device_drivers/ethernet/nebula-matrix/nbl.rst
> new file mode 100644
> index 000000000000..ff38302968c5
> --- /dev/null
> +++ b/Documentation/networking/device_drivers/ethernet/nebula-matrix/nbl.rst
> @@ -0,0 +1,28 @@
> +.. SPDX-License-Identifier: GPL-2.0
> +
> +================================================================
> +Linux Base Driver for Nebula-matrix m18110-NIC/m18000-NIC family
> +================================================================
> +
> +Overview:
> +=========
> +The m18110-NIC/m18000-NIC is a series of network interface cards for the Data
> +Center Area.
> +
> +The driver supports link-speed 100GbE/25GE/10GE.
> +
> +m18110-NIC/m18000-NIC devices support MSI-X interrupt vector for each Tx/Rx
> +queue and interrupt moderation.
> +
> +m18110-NIC/m18000-NIC devices support also various offload features such as
> +checksum offload, Receive-Side Scaling(RSS).

[Severity: Low]
Do these three statements describe what the driver actually does, either
at this commit or at the end of the series?

Grepping the vendor directory at the last patch of the series
("net/nebula-matrix: add common dev start/stop operation",
9b90629960395de83faaf5146e29ffc3cb854c5b) finds nothing for any of the
netdev or offload plumbing these sentences describe:

  git grep -E 'register_netdev|netdev_ops|alloc_etherdev|ethtool_ops|NETIF_F_' \
      drivers/net/ethernet/nebula-matrix/
  (no matches)

The directory at that point contains only nbl_main.c plus nbl_channel/,
nbl_common/, nbl_core/, nbl_hw/ and nbl_include/, so the code binds the
PCI function, maps the BARs and brings up the PF mailbox, but never
registers a net_device, never programs per-queue Tx/Rx MSI-X vectors, and
has no RSS, checksum offload, interrupt moderation or link-speed
reporting.

Would it make sense to describe only what is implemented, and add the
link speed / per-queue MSI-X / moderation / RSS / checksum text in the
patches that introduce those features?

> +
> +Support
> +=======
> +
> +For more information about m18110-NIC/m18000-NIC, please visit the following URL:
> +https://www.nebula-matrix.com/snic_s1000_en

Is this the right product page?  The URL names snic_s1000, while
nbl_main.c documents the matched IDs as "SNIC v3r1 product Device IDs
range: 0x3403-0x3412" for m18110/m18000.

> +
> +If an issue is identified with the released source code on the supported kernel
> +with a supported adapter, email the specific information related to the issue to
> +open@xxxxxxxxxxxxxxxxx.

[ ... ]

> diff --git a/drivers/net/ethernet/nebula-matrix/Kconfig b/drivers/net/ethernet/nebula-matrix/Kconfig
> new file mode 100644
> index 000000000000..f16e9663eaed
> --- /dev/null
> +++ b/drivers/net/ethernet/nebula-matrix/Kconfig

[ ... ]

> +config NBL
> +	tristate "Nebula-matrix Ethernet Controller m18110/m18000 support"
> +	depends on PCI && (64BIT || COMPILE_TEST) && !CPU_BIG_ENDIAN
> +	help
> +	  This driver supports Nebula-matrix Ethernet Controller m18110/m18000
> +	  Family of devices.
> +
> +	  More specific information on configuring the driver is in
> +	  <file:Documentation/networking/device_drivers/ethernet/nebula-matrix/nbl.rst>.

The help text points users at the .rst above as the description of the
option's capabilities, so the same over-claim reaches anyone selecting
CONFIG_NBL: the prompt says "Ethernet Controller m18110/m18000 support",
but no network interface is created by any commit in this series.

[ ... ]

-- 
Sashiko AI review · https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20260831021408.2325-1-illusion.wang%40nebula-matrix.com