Re: [PATCH] x86/mm: Introduce helper for checking direct map 1G page support

[Sohil Mehta]

On 9/3/2026 7:05 AM, Dave Hansen wrote:
> But even when writing this, I was
> forgetful about what CONFIG_X86_DIRECT_GBPAGES actually did. I _think_
> it was the fact that these:
> 
> 	CONFIG_X86_DIRECT_GBPAGES
> 	X86_FEATURE_GBPAGES
> 
> kinda read similarly if you're reading fast. The config option also
> doesn't have the most enlightening name.

Yes, the config option is a bit vague.

> 
> The comments are more there to get the reader to slow down than anything
> else.

Sure, makes sense.

> First and foremost, in a refactoring patch, you must resist the urge to
> do this. Refactoring patches' job is to show -- in the most plain way
> possible -- that they are not hurting things. The easiest way to do that
> is to make it as stupidly obvious as possible to the reader that nothing
> is changing.
> 

Yeah, I was trying to sneak in a minor cleanup along with the refactor.
Will avoid it next time I do a refactor.