Re: [PATCH v2 1/3] dt-bindings: nvmem: uniphier-efuse: Add ti,am62p-efuse compatible

From: Conor Dooley

Date: Thu Sep 03 2026 - 14:03:44 EST


On Wed, Sep 02, 2026 at 05:27:57PM -0500, Judith Mendez wrote:
> Add ti,am62p-efuse as a compatible string to the uniphier-efuse binding.
> The uniphier-efuse driver can be used to read AM62P efuse registers as
> well for GP_SW silicon revision detection.
>
> Signed-off-by: Judith Mendez <jm@xxxxxx>

Why is a fallback compatible not suitable here?
Either it is, and you should add one, or you need to explain in hte
commit message why it is not.

pw-bot: changes-requested

Thanks,
Conor.

> ---
> .../devicetree/bindings/nvmem/socionext,uniphier-efuse.yaml | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/nvmem/socionext,uniphier-efuse.yaml b/Documentation/devicetree/bindings/nvmem/socionext,uniphier-efuse.yaml
> index e27cbae2d63a0..5e1b90fc1ae45 100644
> --- a/Documentation/devicetree/bindings/nvmem/socionext,uniphier-efuse.yaml
> +++ b/Documentation/devicetree/bindings/nvmem/socionext,uniphier-efuse.yaml
> @@ -16,7 +16,9 @@ allOf:
>
> properties:
> compatible:
> - const: socionext,uniphier-efuse
> + enum:
> + - socionext,uniphier-efuse
> + - ti,am62p-efuse
>
> reg:
> maxItems: 1
> --
> 2.34.1
>

Attachment: signature.asc
Description: PGP signature