Re: [PATCH v10 04/11] x86/virt/tdx: Allocate refcounts for Dynamic PAMT memory

[Edgecombe, Rick P]

On Thu, 2026-09-03 at 08:30 -0700, Dave Hansen wrote:
> On 9/2/26 18:51, Rick Edgecombe wrote:
> > @@ -2159,7 +2210,7 @@ static void __tdx_pamt_put(kvm_pfn_t pfn)
> >    * This function is currently only safe to call once. And not safe to call
> >    * if __tdx_pamt_get() is called before or after.
> >    */
> > -static struct page * __maybe_unused __tdx_alloc_control_page(void)
> > +static __maybe_unused struct page *__tdx_alloc_control_page(void)
> >   {
> >   	struct page *page;
> >   
> > @@ -2184,7 +2235,7 @@ static struct page * __maybe_unused __tdx_alloc_control_page(void)
> >    * it, and no other pages in the aligned 2MB physical region will
> >    * still need the backing.
> >    */
> > -static void __maybe_unused __tdx_free_control_page(struct page *page)
> > +static __maybe_unused void __tdx_free_control_page(struct page *page)
> >   {
> 
> What's with all the __maybe_unused order flipping?

Oops, it was applied to the wrong patch. Should be the previous one.

While applying some other changes in the middle of the series, I got build
warning on the order of the attribute and the rest of the signature being wrong.
Somehow the CI bisectability test missed it. Then I applied the change to the
wrong patch.