Re: [PATCH v3] nvme-tcp.h: drop kernel-doc comments, fix a few descriptions

From: Keith Busch

Date: Thu Sep 03 2026 - 16:58:16 EST


On Sun, Aug 30, 2026 at 11:05:01PM -0700, Randy Dunlap wrote:
> Expand @fei into @feil and @feih because the field was split due to it
> not being 32-bit aligned.
>
> Struct member @hdr was described twice in struct nvme_tcp_rsp_pdu, so
> drop one of them.
>
> These structs are defined in a spec outside of the kernel, so kernel-doc
> comments for them aren't needed here as well.
>
> This avoids kernel-doc warnings:
>
> Warning: include/linux/nvme-tcp.h:95 struct member 'rsvd2' not described in 'nvme_tcp_icreq_pdu'
> Warning: include/linux/nvme-tcp.h:113 struct member 'rsvd' not described in 'nvme_tcp_icresp_pdu'
> Warning: include/linux/nvme-tcp.h:128 struct member 'feil' not described in 'nvme_tcp_term_pdu'
> Warning: include/linux/nvme-tcp.h:128 struct member 'feiu' not described in 'nvme_tcp_term_pdu'
> Warning: include/linux/nvme-tcp.h:128 struct member 'rsvd' not described in 'nvme_tcp_term_pdu'
> Warning: include/linux/nvme-tcp.h:169 struct member 'rsvd' not described in 'nvme_tcp_r2t_pdu'
> Warning: include/linux/nvme-tcp.h:187 struct member 'rsvd' not described in 'nvme_tcp_data_pdu'

Thanks, applied to nvme-7.3.