Re: [net-next,v6,5/6] selftests: net: add multithread server support to iou-zcrx
From: Juanlu Herrero
Date: Thu Sep 03 2026 - 16:59:17 EST
On Thu, Sep 03, 2026 at 01:06:11PM -0600, Paolo Abeni wrote:
>
>
> On 9/3/26 1:38 AM, netdev-bot+sashiko@xxxxxxxxxx wrote:
> > Thank you for your contribution! Sashiko AI review found 6 potential
> > issue(s) to consider:
> >
> > Critical: 0 · High: 1 · Medium: 2 (3) · Low: 3
> >
> > - [High] listen() is now executed before the workers have registered
> > their zcrx ifqs, breaking the ordering that two existing in-tree tests…
> > - [Medium] A worker thread that is dispatched zero connections reports
> > success without receiving or verifying a single byte.
> > - [Medium] The new CQ sizing removes the implicit bound that kept the
> > zcrx refill-queue producer inside one ring.
>
> My understanding is that the above 3 concerns may affect tests stability
> and should be addressed before merging.
>
> Thanks,
>
> Paolo
>
makes sense, I will address these in v7 of this patchset.
Best,
Juanlu