Re: [PATCH v4 2/2] can: m_can: add ti,am62-m_can compatible with out-of-band wakeup support

[Kendall Willis]

Hi Krzysztof,
On 15:46-20260903, Krzysztof Kozlowski wrote:
> On Wed, Sep 02, 2026 at 04:03:28PM -0500, Kendall Willis wrote:
> > +struct m_can_pdata {
> > +	bool out_band_wakeup;
> > +};
> > +
> >  struct m_can_classdev *m_can_class_allocate_dev(struct device *dev, int sizeof_priv);
> >  void m_can_class_free_dev(struct net_device *net);
> >  int m_can_class_register(struct m_can_classdev *cdev);
> > diff --git a/drivers/net/can/m_can/m_can_platform.c b/drivers/net/can/m_can/m_can_platform.c
> > index 56da411878af0185ff9cc512e325137428a68255..ae2d89b65fe8da65b1ca73cbf80cd8ee8483e2e8 100644
> > --- a/drivers/net/can/m_can/m_can_platform.c
> > +++ b/drivers/net/can/m_can/m_can_platform.c
> > @@ -218,8 +218,13 @@ static const struct dev_pm_ops m_can_pmops = {
> >  	SET_SYSTEM_SLEEP_PM_OPS(m_can_suspend, m_can_resume)
> >  };
> >  
> > +static const struct m_can_pdata m_can_plat_am62 = {
> > +	.out_band_wakeup = true,
> > +};
> > +
> >  static const struct of_device_id m_can_of_table[] = {
> >  	{ .compatible = "bosch,m_can", .data = NULL },
> > +	{ .compatible = "ti,am62-m_can", .data = &m_can_plat_am62 },
> 
> How exactly having out of band wakeup makes this device INCOMPATIBLE
> with Bosch (in terms of DT compatibility)?
> 

It does not make it incompatible with Bosch. The DT binding is
incorrect for having it be compatible with both TI and Bosch. I'm
correcting it on the next revision.

Best,
Kendall