Re: [PATCHv2 net] net: ll_temac: Return actual error from of_get_mac_address()
From: Andrew Lunn
Date: Thu Sep 03 2026 - 18:07:26 EST
On Wed, Sep 02, 2026 at 02:02:38PM -0700, Rosen Penev wrote:
> When of_get_mac_address() fails, return the actual error code (rc)
> instead of the hardcoded -ENODEV. This preserves the original error
> information, which may be more specific (e.g., -EINVAL, -EPROBE_DEFER)
> and helps callers handle the failure appropriately.
>
> Use dev_err_probe() to avoid printing an extra error message in case of
> -EPROBE_DEFER.
>
> Fixes: 8425c41d1ef7 ("net: ll_temac: Extend support to non-device-tree platforms")
> Assisted-by: opencode:big-pickle
> Signed-off-by: Rosen Penev <rosenp@xxxxxxxxx>
Does this bother anybody? Have you seen the extra error message?
Maybe net-next would be a better target.
Andrew