RE: [PATCH v5 0/3] x86/mce: Fix timer list corruption and avoid redundant polling

[Luck, Tony]

Hi Aaron,

> Sashiko [1] has correctly highlighted additional pre-existing race
> conditions in this area. Should you prefer, I would be more than happy to
> incorporate the fixes for these into the current series?
>
> [1]: https://sashiko.dev/#/patchset/20260903194130.186096-1-atomlin%40atomlin.com

I'm not sure about the first Sashiko issue ... there is a wrong statement:
 
   Since the hardware threshold for a stormy bank is set to
   CMCI_STORM_THRESHOLD and no longer generates interrupts,

Setting the storm threshold doesn't disable interrupts. It just prevents
generation of a new interrupt from a bank until enough errors are logged
to meet the threshold. So the user won't see logs for a while. But should
another storm occur, then things will fix themselves without a reboot.

If you see an elegant solution to this race, then go ahead with a patch. But
I wouldn't stress if this one isn't fixed.

The second report regarding firmware first banks does look easy to solve.
Just change cmci_skip_banks() to clear the bit in mce_poll_banks?

-Tony