Re: [PATCH v4 1/5] pci_ids: Add Hygon Family 0x18 DF F3/F4 device IDs

[Bjorn Helgaas]

On Tue, Sep 01, 2026 at 03:16:56PM +0800, Lin Wang wrote:
> Hygon Family 0x18 node discovery identifies Data Fabric misc (F3) and
> link (F4) functions by PCI ID rather than a fixed PCI slot.
> 
> Models 0x04 use 0x1463/0x1464, with 0x1493/0x1494 on the mixed-silicon
> variant. Models 0x05 through 0x08 use 0x14b3/0x14b4.
> 
> Some IDs have the same numeric values as AMD DF devices. PCI identity
> also includes the vendor, so Hygon-prefixed names keep the two vendors'
> definitions independent.
> 
> Signed-off-by: Lin Wang <wanglin@xxxxxxxxxxxxxx>
> ---
>  include/linux/pci_ids.h | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h
> index 63774ae2bf71..d9f3e01033f9 100644
> --- a/include/linux/pci_ids.h
> +++ b/include/linux/pci_ids.h
> @@ -2615,6 +2615,12 @@
>  #define PCI_VENDOR_ID_ROCKCHIP		0x1d87
>  
>  #define PCI_VENDOR_ID_HYGON		0x1d94
> +#define PCI_DEVICE_ID_HYGON_18H_M04H_DF_F3	0x1463
> +#define PCI_DEVICE_ID_HYGON_18H_M04H_DF_F4	0x1464
> +#define PCI_DEVICE_ID_HYGON_18H_M04H_DF_F3B	0x1493
> +#define PCI_DEVICE_ID_HYGON_18H_M04H_DF_F4B	0x1494
> +#define PCI_DEVICE_ID_HYGON_18H_M05H_DF_F3	0x14b3
> +#define PCI_DEVICE_ID_HYGON_18H_M05H_DF_F4	0x14b4

It looks like these are only needed in one place, so per the note:

 *      Do not add new entries to this file unless the definitions
 *      are shared between multiple drivers.

the #defines should probably be added in the
arch/x86/kernel/hygon_node.c (or just use the raw hex values).

This helps reduce conflicts when backporting changes like this.